KAFKA-18628: Add node.id to the metrics reporter config override - #23097
Open
mingyen066 wants to merge 2 commits into
Open
KAFKA-18628: Add node.id to the metrics reporter config override#23097mingyen066 wants to merge 2 commits into
mingyen066 wants to merge 2 commits into
Conversation
Member
|
@mingyen066 would you mind adding a test to ensure the props passed to the reporter include both id configs? |
Collaborator
Author
|
@chia7712 Added the test — it caught a real issue: without the fix, a dynamic update passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicMetricReporterStateoverrides onlybroker.idwhen configuringmetrics reporters. Since
broker.idwill no longer be passed to pluginsfrom 5.0 (KIP-1232), pass
node.idalongside it.This also fixes an inconsistency: reconfigurables are handed
KafkaConfig#valuesFromThisConfig, so a reporter recreated by a dynamicupdate saw
node.idas anIntegerwhilebroker.idwas aString.Both are now passed as strings, matching what reporters see at startup.
Raised in
#22977 (comment).
Reviewers: Chia-Ping Tsai chia7712@gmail.com