[To dev/1.3][Pipe] Optimize pipe TsFile cleanup on drop (#18163)#18303
Open
Caideyipi wants to merge 1 commit into
Open
[To dev/1.3][Pipe] Optimize pipe TsFile cleanup on drop (#18163)#18303Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
* Optimize pipe TsFile cleanup on drop * Use ThreadName for pipe TsFile cleanup executor * Make pipe TsFile cleanup thread lazy * Use IoTDB thread pool factory for pipe cleanup * Clarify pipe TsFile cleanup deletion guard * Reuse periodical cleaner for Pipe TsFile cleanup * Clarify stale Pipe dir collection * Revert "Clarify stale Pipe dir collection" This reverts commit 25625fb. * Avoid duplicate stale Pipe dir collection (cherry picked from commit 350c6c7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #18163 to dev/1.3, cherry-picked from commit 350c6c7.
This optimizes cleanup after a Pipe is dropped by avoiding per-file deletion during resource release, moving the whole stale Pipe TsFile directory aside, and submitting it to the throttled periodical cleaner.
Adaptations for dev/1.3:
Tests:
Both commands passed, including DataNode compilation, Checkstyle, and Spotless checks.