[Pipe] Improve timeout diagnostics and DROP PIPE observability#18297
Open
Caideyipi wants to merge 2 commits into
Open
[Pipe] Improve timeout diagnostics and DROP PIPE observability#18297Caideyipi wants to merge 2 commits into
Caideyipi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the observability of Pipe control procedures, especially when the client times out while the Procedure continues running in the background.
Improve timeout diagnostics for Pipe control statements
When CREATE PIPE, ALTER PIPE, START PIPE, STOP PIPE, or DROP PIPE times out while waiting for its Procedure, the returned diagnostic message now includes:
The diagnostic state is volatile and non-persistent, so it does not affect Procedure execution or recovery. Internal consensus Pipe procedures retain their optimistic timeout behavior.
Make timed-out DROP PIPE observable through SHOW PIPES
The new DROP PIPE flow is:
At PRE_DELETE, ConfigNode persists the Pipe runtime status as PRE_DELETE. Therefore:
Compatibility
The implementation reuses DropPipeProcedureV2 while preserving persisted data compatibility:
Tests
Added coverage for:
Local verification:
The complete ConfigNode Maven test invocation is currently blocked locally by pre-existing generated Thrift/cache API mismatches in this checkout.
This PR has:
Key changed/added classes