Skip to content

Fix PBTree schema cache release after pre-delete (#17834)#17852

Open
Caideyipi wants to merge 1 commit into
dev/1.3from
cp-d182c87-dev-1.3
Open

Fix PBTree schema cache release after pre-delete (#17834)#17852
Caideyipi wants to merge 1 commit into
dev/1.3from
cp-d182c87-dev-1.3

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

Backport d182c87 to dev/1.3.

This fixes PBTree schema cache release after pre-delete by releasing skipped pre-deleted measurement nodes during traversal and making forceFlushAndRelease wait for worker tasks before checking/releasing cached nodes.


This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.

Key changed/added classes (or packages if there are too many classes) in this PR
  • ReleaseFlushMonitor
  • Traverser
  • SchemaStatisticsTest
Tests
  • PASS: mvn -DskipTests spotless:check -pl iotdb-core/datanode
  • FAIL: mvn -pl iotdb-core/datanode -Dtest=SchemaStatisticsTest test (compilation failed while reading many unrelated Java source files, for example SchemaQueryScanNode.java and MergeSortKey.java; the cherry-picked files were not reported as compile errors)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.57%. Comparing base (b885269) to head (2d844de).
⚠️ Report is 3 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
.../mtree/impl/pbtree/memory/ReleaseFlushMonitor.java 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev/1.3   #17852   +/-   ##
==========================================
  Coverage      42.56%   42.57%           
  Complexity       241      241           
==========================================
  Files           3621     3621           
  Lines         240247   240260   +13     
  Branches       29263    29263           
==========================================
+ Hits          102257   102286   +29     
+ Misses        137990   137974   -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant