IGNITE-28971 SQL Calcite: Introduce value resolver for FETCH, OFFSET, and LIMIT - #13467
Open
tkalkirill wants to merge 3 commits into
Open
IGNITE-28971 SQL Calcite: Introduce value resolver for FETCH, OFFSET, and LIMIT#13467tkalkirill wants to merge 3 commits into
tkalkirill wants to merge 3 commits into
Conversation
zstan
reviewed
Aug 12, 2026
zstan
approved these changes
Aug 18, 2026
zstan
left a comment
zstan
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, plz check my comments i`d prefer to call also @alex-plekhanov as an ideolog of Contexts extensions.
| private SqlValidator validator() { | ||
| if (validator == null) | ||
| validator = new IgniteSqlValidator(operatorTbl, catalogReader, typeFactory, validatorCfg, ctx.parameters()); | ||
| validator = createSqlValidator(catalogReader); |
Contributor
There was a problem hiding this comment.
I understand that it`s all about code unification - but nethertheless it`s strange to pass already existing 'catalogReader' here.
| throw new IllegalArgumentException("Negative value for " + op); | ||
|
|
||
| return IgniteMath.convertToLongExact(paramAsDecimal, RoundingMode.DOWN); | ||
| IgniteSqlPaginationPolicy pagPlc = ctx.unwrap(IgniteSqlPaginationPolicy.class); |
Contributor
There was a problem hiding this comment.
let`s add @Nullable to PlanningContext#unwrap ?
Probably it would be clear to unify this code and the equal from IgniteSqlValidator#checkLimitOffset ->
a mean this :
RoundingMode roundingMode = pagPlc == null ? IgniteMath.NUMERIC_ROUNDING_MODE : pagPlc.roundingMode();
IgniteMath.convertToLongExact(val, roundingMode);
Contributor
Author
There was a problem hiding this comment.
I fixed all of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28971