Skip to content

IGNITE-28498 Use MessageSerializer for Zookeeper discovery custom messages#13000

Merged
NSAmelchev merged 5 commits intoapache:masterfrom
NSAmelchev:ignite-28498
Apr 16, 2026
Merged

IGNITE-28498 Use MessageSerializer for Zookeeper discovery custom messages#13000
NSAmelchev merged 5 commits intoapache:masterfrom
NSAmelchev:ignite-28498

Conversation

@NSAmelchev
Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@NSAmelchev NSAmelchev changed the title IGNITE-28498 Remove Serializable from Zookeeper discovery custom messages IGNITE-28498 Use MessageSerializer for Zookeeper discovery custom messages Apr 14, 2026
@github-actions
Copy link
Copy Markdown

Possible compatibility issues. Please, check rolling upgrade cases

This PR modifies protected classes (with Order annotation).
Changes to these classes can break rolling upgrade compatibility.

Affected files:

  • modules/codegen/src/main/java/org/apache/ignite/internal/MessageProcessor.java
  • modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/msg/GridH2Null.java

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@chesnokoff chesnokoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked and reproduced the patch using IDEA Safe Delete. Works fine

@chesnokoff
Copy link
Copy Markdown
Contributor

disregard previous review

Copy link
Copy Markdown
Contributor

@chesnokoff chesnokoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NSAmelchev NSAmelchev merged commit 197a144 into apache:master Apr 16, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants