fix(connectors): propagate sink plugin consume failure status - #3951
Open
minleejae wants to merge 1 commit into
Open
fix(connectors): propagate sink plugin consume failure status#3951minleejae wants to merge 1 commit into
minleejae wants to merge 1 commit into
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
kriti-sc
reviewed
Aug 22, 2026
| // the SDK returns non-zero when the sink's consume() errors or the batch cannot | ||
| // be deserialized. Ignoring it would count the batch as processed and advance | ||
| // consumer offsets over messages the sink never stored — the same silent-loss | ||
| // class that the iggy_sink_open status check prevents at startup. |
Contributor
There was a problem hiding this comment.
while I agree that the plugin should exit when plugin returns non-zero status, simply exitting the plugin does not solve the problem highlighted in the issue.
I think we should fix the comment and update the issue description to reflect this.
Also see discussion: #2927
kriti-sc
suggested changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binds the
iggy_sink_consumeFFI status and returnsRuntimeError::SinkConsumeFailed { plugin_id, status }on non-zero, matching the existingiggy_sink_opencheck in the same file. The caller's existingErrpath handles logging and skips the processed counter, so a failed batch is no longer counted as processed.Includes a regression test with stub
extern "C"callbacks for both paths — the failure-path test fails on master withexpected SinkConsumeFailed, got successand passes with this change.Closes #3950