Skip to content

fix(consensus): keep a late retry's reply instead of refusing it - #3945

Open
numinnex wants to merge 4 commits into
masterfrom
fix_late_reply
Open

fix(consensus): keep a late retry's reply instead of refusing it#3945
numinnex wants to merge 4 commits into
masterfrom
fix_late_reply

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 21, 2026
@numinnex

Copy link
Copy Markdown
Contributor Author

Merge after #3944

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.81869% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.24%. Comparing base (c0c7493) to head (0be79b0).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...SDK/IggyClient/Implementations/TcpMessageStream.cs 72.88% 12 Missing and 4 partials ⚠️
core/sdk/src/leader_aware.rs 80.00% 13 Missing ⚠️
core/sdk/src/tcp/tcp_client.rs 90.51% 10 Missing and 3 partials ⚠️
foreign/go/client/tcp/tcp_core.go 80.76% 7 Missing and 3 partials ⚠️
core/consensus/src/client_table.rs 96.36% 4 Missing and 4 partials ⚠️
core/shard/src/router.rs 62.50% 3 Missing ⚠️
foreign/node/src/client/client.connection.ts 95.45% 2 Missing and 1 partial ⚠️
core/server_common/src/consensus_message.rs 85.71% 0 Missing and 2 partials ⚠️
foreign/go/client/tcp/tcp_session_management.go 81.81% 1 Missing and 1 partial ⚠️
...figuration/tcp_config/tcp_client_config_builder.rs 95.65% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3945      +/-   ##
============================================
- Coverage     83.87%   82.24%   -1.64%     
+ Complexity     1358     1355       -3     
============================================
  Files          1212     1213       +1     
  Lines        166843   167114     +271     
  Branches     134306   134603     +297     
============================================
- Hits         139937   137437    -2500     
- Misses        23266    26012    +2746     
- Partials       3640     3665      +25     
Components Coverage Δ
Rust Core 84.48% <91.78%> (-0.17%) ⬇️
Java SDK 66.61% <ø> (-0.07%) ⬇️
C# SDK 46.73% <77.14%> (-29.82%) ⬇️
Python SDK 90.13% <ø> (ø)
PHP SDK 84.48% <ø> (ø)
Node SDK 95.96% <95.89%> (+0.11%) ⬆️
Go SDK 68.37% <80.95%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
core/binary_protocol/src/consensus/header.rs 81.56% <ø> (ø)
core/binary_protocol/src/consensus/operation.rs 97.54% <100.00%> (+0.06%) ⬆️
.../src/traits/binary_impls/personal_access_tokens.rs 100.00% <ø> (ø)
core/common/src/traits/binary_impls/users.rs 100.00% <ø> (ø)
core/common/src/traits/binary_transport.rs 100.00% <100.00%> (ø)
...ypes/configuration/tcp_config/tcp_client_config.rs 100.00% <100.00%> (ø)
core/consensus/src/metadata_helpers.rs 93.93% <100.00%> (+0.01%) ⬆️
core/sdk/src/client_provider.rs 48.36% <100.00%> (+0.33%) ⬆️
core/server/src/partition_reconciler.rs 97.80% <100.00%> (+0.03%) ⬆️
core/shard/src/metrics.rs 86.55% <ø> (ø)
... and 19 more

... and 109 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant