GCP: Fix GCSInputStream Javadoc describing streaming uploads#17273
Draft
thswlsqls wants to merge 1 commit into
Draft
GCP: Fix GCSInputStream Javadoc describing streaming uploads#17273thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
GCSInputStream is a read-only stream: it extends SeekableInputStream, implements RangeReadable, and only ever opens a ReadChannel through storage.reader(). Its class Javadoc described it as being for streaming uploads and linked to the upload docs page. The wording was copied from GCSOutputStream, which was added in the same commit (apache#3711) and where "uploads" is correct. Point the text and the link at streaming downloads instead. Generated-by: Claude Code
thswlsqls
marked this pull request as draft
July 17, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GCSInputStreamis read-only: it extendsSeekableInputStream, implementsRangeReadable, and only opens aReadChannelviastorage.reader(). Its class Javadoc described it as being for "streaming uploads", and the old link resolves to the upload docs (/storage/docs/uploads).GCSOutputStream, added in the same commit (Add FileIO implementation for Google Cloud Storage #3711), where "uploads" is correct — soGCSOutputStreamis left untouched.https://cloud.google.com/storage/docs/streaming-downloads, whose title matches the anchor text.Testing done
./gradlew :iceberg-gcp:spotlessCheckpassed.