Dell: Throw NoSuchNamespaceException when updating missing namespace#17271
Draft
thswlsqls wants to merge 1 commit into
Draft
Dell: Throw NoSuchNamespaceException when updating missing namespace#17271thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
EcsCatalog.setProperties() and removeProperties() share updateProperties(), which read the namespace properties object without checking that the namespace exists. For a missing namespace the ECS SDK raised a raw S3Exception (404 NoSuchKey) instead of the NoSuchNamespaceException both methods declare. Check namespaceExists() first, matching loadNamespaceMetadata(), listNamespaces() and dropNamespace() in the same class, and the sibling catalogs InMemoryCatalog, JdbcCatalog and GlueCatalog. Generated-by: Claude Code
thswlsqls
marked this pull request as draft
July 17, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17270
Summary
EcsCatalog.setProperties()andremoveProperties()leaked the vendor exceptioncom.emc.object.s3.S3Exception(404NoSuchKey) for a missing namespace.updateProperties(), which calledloadProperties()with no existence check;loadProperties()does not translate 404, unlikeobjectMetadata().InMemoryCatalog,JdbcCatalog,GlueCatalog— as doesloadNamespaceMetadata()here.EcsCatalogwas the only leak.throws NoSuchNamespaceException.SupportsNamespacesmarks that@throws(optional), which permits not throwing — not leaking a vendor exception.Namespace.empty()(root) has no properties object, so it now raisesNoSuchNamespaceExceptionrather thanS3Exception; only the exception type changes.The check follows the dominant idiom in this class (
listNamespaces(),dropNamespace()):Testing done
TestEcsCatalog#namespacePropertiesOfMissingNamespacecovering both methods; it fails onmainwithS3Exception../gradlew :iceberg-dell:check— 26 tests passed.dell/is outside the published REVAPI modules, so no revapi run.