OpenAPI, Core: Add VariantType to the REST catalog spec#17256
Open
nssalian wants to merge 1 commit into
Open
Conversation
Co-authored-by: Amogh Jahagirdar <amoghj@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for the change
Adds the variant type to the REST catalog OpenAPI spec so that variant columns are representable in table schemas exchanged over the REST protocol.
Builds on #14242. That change modeled variant as an object (
{"type": "variant"}); this change instead models it as a bare stringconst: "variant"to match howSchemaParserserializes it on the wire (SchemaParserwrites the type as the string"variant")Changes
open-api/rest-catalog-open-api.yamlAdded aVariantTypeschemaopen-api/rest-catalog-open-api.py- regenerated viamake generateTesting
testCreateTableWithVariantColumntoCatalogTests. The test creates a format-v3 table with a variant column and asserts the schema round-trips through the catalog. Enabled forTestRESTCatalogand the REST compatibility kit (RESTCompatibilityKitCatalogTests)