Azure: Return fully-qualified locations from ADLSFileIO.listPrefix#17248
Draft
thswlsqls wants to merge 1 commit into
Draft
Azure: Return fully-qualified locations from ADLSFileIO.listPrefix#17248thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
ADLSFileIO.listPrefix returned each file's location as a path relative to the filesystem container root (e.g. "dir/file"), while the sibling S3FileIO and GCSFileIO return fully-qualified URIs. The relative path cannot be fed back into ADLSLocation, so it fails validation when round-tripped through FileSystemWalker (used by opt-in prefix-based orphan file cleanup). Reconstruct the full URI from the prefix location, preserving its scheme, container, and host. Add ADLSLocation.scheme() to expose the captured scheme. Generated-by: Claude Code
thswlsqls
marked this pull request as draft
July 17, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17247
Summary
ADLSFileIO.listPrefix()returned each file's location as a container-relative path (dir/file) instead of a fully-qualified URI.S3FileIObuildss3://bucket/key(S3FileIO.java:348),GCSFileIObuildsgs://bucket/name(GCSFileIO.java:302).ADLSLocationcannot parse a relative path, so it throwsValidationExceptionwhenFileSystemWalkerround-trips it (opt-in SparkusePrefixListing, Flink maintenance orphan cleanup).ADLSLocation.scheme()to expose the captured scheme.Testing done
TestADLSFileIO#listPrefixReturnsFullyQualifiedLocation(unit, Mockito) asserting the location isabfss://container@account.dfs.core.windows.net/dir/file../gradlew :iceberg-azure:test --tests "...TestADLSFileIO"— 13 tests passed.:iceberg-azure:spotlessCheck :iceberg-azure:checkstyleMain :iceberg-azure:checkstyleTest— passed.src/integration/.../TestADLSFileIO#testListPrefixOperationsassertion to the full URI. Not run locally, along with:iceberg-azure:check, since both need Docker/Azurite.