Flink: Fix timestamp-micros conversion in AvroToRowDataConverters

[kinolaev]

Avro timestamp-micros values were converted to TimestampData by multiplying the microsecond remainder by 1_000_000 instead of 1000, producing an out-of-range nanoOfMillisecond and throwing IllegalArgumentException. Tests didn't catch it because microsecond remainder was 0. I added a non-zero microsecond component to DataGenerators' shared timestamp fixture.

Closes #17075.

[pvary]

is this the same one as #17078?

We need a test to prevent regression which fails before the patch, and succeeds after the patch.
Also please create a PR for Filnk 2.1 first, and after that PR got merged, then create a backport PR which contains the same changes to Flink 2.0, and Flink 1.20.

Thanks,
Peter

[kinolaev]

You are right @pvary, I'm sorry - this is the same as #17078.

The test org.apache.iceberg.flink.sink.TestAvroGenericRecordToRowDataMapper fails before the patch because org.apache.iceberg.flink.DataGenerators now produces timestamps with a non-zero microsecond component.

I have removed the changes to v1.20/v2.0. I'll keep this PR open in case you prefer to merge this one instead of #17078 for any reason.

[pvary]

Merged to main.
Thanks @kinolaev for the fix!

Please create the backport PR.

[kinolaev]

Thanks @pvary ! Here is the backport PR #17212. All checks have already passed.

[kinolaev]

I think it's worth backporting the fix to the 1.11.x and perhaps 1.10.x branches. @pvary, do I need to create new PRs for this?

[pvary]

I think it's worth backporting the fix to the 1.11.x and perhaps 1.10.x branches.

I don't expect new releases in 1.10.x.
Please backport to 1.11.x

[kinolaev]

Here is the backport PR #17255 to 1.11.x, all checks have passed.