feat(writer): URL encode field names for partition paths#2875
Open
hsiang-c wants to merge 2 commits into
Open
Conversation
hsiang-c
marked this pull request as ready for review
July 21, 2026 23:49
CTTY
reviewed
Jul 23, 2026
CTTY
left a comment
CTTY
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! I have left some comments
| field | ||
| .transform | ||
| .to_human_string(&field_types[i].field_type, value) | ||
| urlencoding::encode(field.name.as_str()).into_owned(), |
Collaborator
There was a problem hiding this comment.
I took a look at Java's code and noticed that java's URLEncoder actually follows application/x-www-form-urlencoded rather than RFC 3986. If we want to be as close as to java's behavior, then we should use form_urlencoded, which implements the application/x-www-form-urlencoded serializer
This actually makes a difference as form_urlencoded and java URLEncoder will convert space to +, while urlencoding will convert space to %20. and space is the most common special character used
| typed-builder = { workspace = true } | ||
| typetag = { workspace = true } | ||
| url = { workspace = true } | ||
| urlencoding = "2.1.3" |
Collaborator
There was a problem hiding this comment.
We should maintain this version in the root Cargo.toml
| } | ||
|
|
||
| #[test] | ||
| fn test_location_generate_with_special_characters_partitionq() { |
Collaborator
There was a problem hiding this comment.
typo:
Suggested change
| fn test_location_generate_with_special_characters_partitionq() { | |
| fn test_location_generate_with_special_characters_partition() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
partition_to_pathfunction so that we can tolerate schema with special characters in the fields.Are these changes tested?
Unit tests