fix(datetime): raise specific "Missing zone offset" error in timestamptz_to_nanos#3505
Open
vishnuprakaz wants to merge 1 commit into
Open
Conversation
offset' error in timestamptz_to_nanos
ebyhr
approved these changes
Jun 21, 2026
Comment on lines
+138
to
+140
| def test_timestamp_to_nanos_unexpected_zone_offset() -> None: | ||
| with pytest.raises(ValueError, match="Zone offset provided, but not expected: 2025-02-23T16:21:44.375612001-04:00"): | ||
| timestamp_to_nanos("2025-02-23T16:21:44.375612001-04:00") |
Member
There was a problem hiding this comment.
nit: I'd move this test under test_timestamp_to_nanos so related timestamp_to_nanos tests stay close together.
| if ISO_TIMESTAMP_NANO.fullmatch(timestamptz_str): | ||
| # When we can match a timestamp without a zone, we can give a more specific error | ||
| raise ValueError(f"Missing zone offset: {timestamptz_str} (must be ISO-8601)") | ||
| raise ValueError(f"Invalid timestamp with zone: {timestamptz_str} (must be ISO-8601)") |
Member
There was a problem hiding this comment.
nit: We could add test cases for Invalid timestamp with zone in this method and Invalid timestamp without zone in timestamp_to_nanos as a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
timestamptz_to_nanosshould raise a clear "Missing zoneoffset" error when it's given a nanosecond timestamp that has no
timezone. Today it can't: the check meant to detect a zone-less
timestamp accidentally tests the same pattern as the success
check right above it, so it never matches. The input falls
through to the vague "Invalid timestamp with zone" error
instead.
The fix is one line check the zone-less pattern
(
ISO_TIMESTAMP_NANO) instead, mirroringtimestamptz_to_micros, which already does this correctly.(Introduced in #1632.)
Are these changes tested?
Yes added tests covering the error messages for both
timestamptz_to_nanosandtimestamp_to_nanos.Are there any user-facing changes?
Only a clearer error message: a zone-less nanosecond timestamp
now reports "Missing zone offset" instead of "Invalid timestamp
with zone". No API changes.