feat(view): View object API#3338
Open
gabeiglio wants to merge 4 commits into
Open
Conversation
Contributor
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
There's a couple of places where we use @property on Table. We should match those. It's a little awkward for the API to be table.properties and view.properties()
| """Get the version of this history view.""" | ||
| return self.metadata.version_log | ||
|
|
||
| def properties(self) -> dict[str, str]: |
Contributor
There was a problem hiding this comment.
We should use @property to match Table.
| """Get the version of this view.""" | ||
| return next(version for version in self.metadata.versions if version.version_id == self.metadata.current_version_id) | ||
|
|
||
| def versions(self) -> list[ViewVersion]: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add view api to abstract away access to the metadata
Are these changes tested?
Yes, created tests/test_view.py
Are there any user-facing changes?
Yes, a new api is available for views