Bump daft dependency to >=0.7.10 (fix Python 3.14 compatibility)#3323
Merged
geruh merged 1 commit intoapache:mainfrom May 3, 2026
Merged
Bump daft dependency to >=0.7.10 (fix Python 3.14 compatibility)#3323geruh merged 1 commit intoapache:mainfrom
geruh merged 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up to Python 3.14 support (#3299)
Daft <0.7.10 has a type-checking bug on Python 3.14 where
typing.Unionbecame a propertype, causingdaft.read_iceberg()to rejectTableobjects withAPITypeError.In Python 3.14,
typing.Unionis now a class (isinstance(typing.Union, type)→True). Daft'sisinstance_helperchecksisinstance(origin_T, type)beforeorigin_T is Union, hitting the generic branch instead of decomposing the union args.Are these changes tested?
Yes, tested locally
Note, integration tests only run on Python 3.12 in CI, so this wasn't caught
Are there any user-facing changes?