HIVE-29739: Update Maven Central badge in README.md#6605
Conversation
|
can u point me to the link of the policy as well |
apache/calcite#4862 (review) |
|
that is telling the privacy policy is only for asf website not github. I am not sure about this. Lets wait for Stamatis then |
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
The ASF privacy policy does not apply on github.com so any badge provider is fine and there is no violation at the moment.
Between maven-madges.sml.io and img.shields.io the latter may be a bit better since they have a clearly documented privacy policy.
I am OK to merge it but please reword description to avoid potential confusion. In addition, every Hive PR requires a Jira ticket so please create one and update the PR title.
Signed-off-by: xiedeyantu <czjourney@163.com>
@zabetak Thank you for the detailed explanation; I have created the JIRA ticket and updated the description. I am not yet very familiar with the Hive community's contribution guidelines, so please feel free to contact me if anything seems inappropriate—I would be happy to learn. |
xiedeyantu
changed the title
|
4 participants
What changes were proposed in this pull request?
Replace the Maven Central badge in README.md with the equivalent badge provided by shields.io.
Why are the changes needed?
The current badge provider works correctly, but shields.io has a clearly documented privacy policy and is a better choice for the project.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Verified that the new badge renders correctly by opening the badge URL:
https://img.shields.io/maven-central/v/org.apache.hive/hive.svg?color=brightgreen