HIVE-29729: AIBOE in HiveFilterProjectTransposeRule during CBO planni…#6601
Open
rtrivedi12 wants to merge 2 commits into
Open
HIVE-29729: AIBOE in HiveFilterProjectTransposeRule during CBO planni…#6601rtrivedi12 wants to merge 2 commits into
rtrivedi12 wants to merge 2 commits into
Conversation
…ng for filters over windowing Projects
asf-ci-hive
added
tests pending
tests failed
tests passed
and removed
tests pending
tests failed
labels
soumyakanti3578
approved these changes
Jul 15, 2026
soumyakanti3578
left a comment
soumyakanti3578
left a comment
Contributor
There was a problem hiding this comment.
LGTM as is. There are nits but they are not strictly needed for the PR.
I will merge this sometime tomorrow.
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng for filters over windowing Projects
What changes were proposed in this pull request?
RedundancyChecker.visit(...) in HiveFilterProjectTransposeRule now skips (returns) when it reaches a Project that contains window functions (RexOver), instead of calling pushPastProjectUnlessBloat on it. This mirrors the guard that already exists in onMatch(...) and the visitor's existing "unsupported node → return" behaviour
Why are the changes needed?
isRedundantIsNotNull(...) (added in HIVE-25275) walks down the plan and pushes the predicate past each Project. For a Project holding RexOver expressions, Calcite's pushPastProjectUnlessBloat rewrites the RexInputRefs inside the window PARTITION BY / ORDER BY specs; those refs index into the input row type and can exceed the projection list size, throwing ArrayIndexOutOfBoundsException during CBO planning
Does this PR introduce any user-facing change?
No
How was this patch tested?
mvn test -pl itests/qtest -Pitests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=cbo_filter_pushdown_windowing_notnull.q