HBASE-30150 Propagate filter hints through composite filters#8486
Open
shubham-roy wants to merge 1 commit into
Open
HBASE-30150 Propagate filter hints through composite filters#8486shubham-roy wants to merge 1 commit into
shubham-roy wants to merge 1 commit into
Conversation
mnpoonia
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e45818e)
Description:
Backport of HBASE-30150 to branch-2.5, cherry-picked from master (commit
e45818ee9ae, PR #8217).Stacks on the HBASE-29974 branch-2.5 backport (#8464), which introduced the
Filter#getSkipHint()/Filter#getHintForRejectedRow()API this changepropagates through composite filters.
What this does
Composite/wrapping filters now delegate the seek-hint methods to their
sub-filters instead of silently dropping the hints:
FilterList(MUST_PASS_ALL/MUST_PASS_ONE),SkipFilter, andWhileMatchFilterdelegategetHintForRejectedRow()andgetSkipHint()and merge the results — maximal-step merge for AND, minimal-step (null if
any sub-filter returns null) for OR, consistent with the existing
getNextCellHint()behavior.ColumnRangeFilter,ColumnPrefixFilter, andMultipleColumnPrefixFiltergain
getSkipHint()implementations.Backport notes
Clean cherry-pick — no adaptation was required. The composite-filter classes
are
Cell-based on branch-2.5, so the diff is identical to master. Tests areunchanged from master (JUnit 5).
Impact
No-op by default: the new hint methods default to
null, so existing filtersand scans are unaffected. The optimization only engages for filters that
implement the hints.
Testing
TestFilterHintForRejectedRowandTestFilterListHintDelegation(new)cover forward/reversed scans, AND/OR merge semantics, edge cases, and
data-correctness invariants.
mvn -pl hbase-client,hbase-server -am -DskipTests package).cc @virajjasani