HADOOP-19952. Support Single EKU; Load client keystore when ssl.clien… - #8655
Open
riya2305 wants to merge 3 commits into
Open
HADOOP-19952. Support Single EKU; Load client keystore when ssl.clien…#8655riya2305 wants to merge 3 commits into
riya2305 wants to merge 3 commits into
Conversation
…t.keystore.location is set
riya2305
force-pushed
the
QI-6008-single-eku-client-keystore
branch
from
August 4, 2026 06:34
4bfa660 to
0a8b209
Compare
Contributor
|
Hey @riya2305 ! Thanks for this improvement! |
K0K0V0K
reviewed
Aug 4, 2026
| String keystoreLocationProperty = | ||
| resolvePropertyName(mode, SSL_KEYSTORE_LOCATION_TPL_KEY); | ||
| String keystoreLocation = conf.get(keystoreLocationProperty, ""); | ||
| boolean keystoreFilePresent = !keystoreLocation.isEmpty() |
Contributor
There was a problem hiding this comment.
Maybe a Warning log would be nice if file not found, but configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t.keystore.location is set
Description of PR
FileBasedKeyStoresFactoryignoresssl.client.keystore.*in CLIENT mode unlesshadoop.ssl.require.client.cert=true(default: false). This breaks Single EKUdeployments that configure a dedicated clientAuth keystore in
ssl-client.xml—outbound mTLS connections silently send no client certificate.
This patch loads the keystore when
ssl.client.keystore.locationis set and thefile exists, without requiring the legacy flag. Unset/missing keystore behavior
is unchanged.
How was this patch tested?
For code changes:
declared according to the connector-specific documentation? Note: Automated CI
testing doesn't cover all cases so manual testing with cloud storage is still
required.
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html