HADOOP-19951. Remove use of jetty-util-ajax and use jackson instead - #8654
HADOOP-19951. Remove use of jetty-util-ajax and use jackson instead#8654pjfanning wants to merge 20 commits into
Conversation
ajfabbri
left a comment
There was a problem hiding this comment.
LGTM except I had a couple of questions.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
72979b1 to
181f550
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
rework HadoopJsonUtils HadoopJsonUtils.toStrin
rename as JsonUtils typo
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
There now appears to be just one test class failing and I think this is unrelated to this PR: |
| @Override | ||
| public int hashCode() {return toShort();} | ||
|
|
||
| @JsonValue // For Jackson serialization, use the toString() to represent this object as JSON. |
There was a problem hiding this comment.
It's exposing the Jackson API from the Hadoop API, I'm not sure this is a good choice ...
pan3793
left a comment
There was a problem hiding this comment.
@pjfanning thanks for your effort, I go through the non-test code and pom.xml changes, almost LGTM, but I think we should not add com.fasterxml.jackson.annotation.* to Hadoop public API, and I believe it can be replaced with a caller-side static method or something else that easy to implement.
jackson-annotations is a non-optional dependency of jackson-databind - a heavily used lib in Hadoop This jackson-annotations is already in the Hadoop ecosystem. This PR does not add the dependency. Jackson-Databind is heavily dependent on annotations generally. https://github.com/search?q=repo%3Aapache%2Fhadoop+com.fasterxml.jackson.annotation&type=code |
Description of PR
HADOOP-19951
Contains content generated by Claude / Xiaomi Mimo.
How was this patch tested?
CI build
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html