Skip to content

use Locale.ROOT in StringGroovyMethods.containsIgnoreCase#2567

Merged
paulk-asert merged 1 commit into
apache:masterfrom
netliomax25-code:containsignorecase-locale-root
May 31, 2026
Merged

use Locale.ROOT in StringGroovyMethods.containsIgnoreCase#2567
paulk-asert merged 1 commit into
apache:masterfrom
netliomax25-code:containsignorecase-locale-root

Conversation

@netliomax25-code
Copy link
Copy Markdown
Contributor

containsIgnoreCase lowercases both arguments with the JVM default locale, so
under tr_TR "ADMIN".containsIgnoreCase("admin") returns false — I folds
to dotless ı. Switch to Locale.ROOT, matching the sibling
startsWithIgnoreCase/endsWithIgnoreCase which already fold locale-independently via equalsIgnoreCase.

@testlens-app
Copy link
Copy Markdown

testlens-app Bot commented May 28, 2026

✅ All tests passed ✅

🏷️ Commit: db43ad3
▶️ Tests: 99894 executed
⚪️ Checks: 22/22 completed


Learn more about TestLens at testlens.app.

@paulk-asert paulk-asert merged commit 07ce145 into apache:master May 31, 2026
23 checks passed
@paulk-asert
Copy link
Copy Markdown
Contributor

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants