GROOVY-12020: EnumSet.plus(element) loses EnumSet type under JPMS#2566
Merged
Conversation
Under newer JDKs, ObjectUtil.cloneObject fails for EnumSet because the
MethodHandles.Lookup, teleported into the concrete RegularEnumSet (a
package-private subclass in java.base), lacks the access needed to
unreflect the inherited public clone() method. The IllegalAccessException
is swallowed by DefaultGroovyMethodsSupport.cloneObject's catch-all and
cloneSimilarCollection falls back to LinkedHashSet, so
EnumSet.of(A, B, C) + D
now returns a LinkedHashSet instead of an EnumSet. Subsequent assignment
to an EnumSet-typed variable or field then fails with a GroovyCastException.
Fall back to plain reflective Method.invoke when the MethodHandle Lookup
cannot access clazz. The clone method itself is public, so reflective
invocation succeeds without needing --add-opens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under newer JDKs, ObjectUtil.cloneObject fails for EnumSet because the MethodHandles.Lookup, teleported into the concrete RegularEnumSet (a package-private subclass in java.base), lacks the access needed to unreflect the inherited public clone() method. The IllegalAccessException is swallowed by DefaultGroovyMethodsSupport.cloneObject's catch-all and cloneSimilarCollection falls back to LinkedHashSet, so
now returns a LinkedHashSet instead of an EnumSet. Subsequent assignment to an EnumSet-typed variable or field then fails with a GroovyCastException.
Fall back to plain reflective Method.invoke when the MethodHandle Lookup cannot access clazz. The clone method itself is public, so reflective invocation succeeds without needing --add-opens.