Skip to content

Improve type hints in web unit test support classes - #16093

Draft
matrei wants to merge 1 commit into
8.0.xfrom
test-support-type-hints
Draft

Improve type hints in web unit test support classes#16093
matrei wants to merge 1 commit into
8.0.xfrom
test-support-type-hints

Conversation

@matrei

@matrei matrei commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.3384%. Comparing base (4bc5bd8) to head (2c80e3e).
⚠️ Report is 22 commits behind head on 8.0.x.

Files with missing lines Patch % Lines
...oovy/grails/testing/web/UrlMappingsUnitTest.groovy 40.0000% 3 Missing ⚠️
.../grails/testing/ParameterizedGrailsUnitTest.groovy 0.0000% 0 Missing and 1 partial ⚠️
...testing/web/interceptor/InterceptorUnitTest.groovy 0.0000% 1 Missing ⚠️
...vy/grails/testing/web/taglib/TagLibUnitTest.groovy 50.0000% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##                8.0.x     #16093        +/-   ##
==================================================
- Coverage     52.3426%   52.3384%   -0.0042%     
+ Complexity      18293      18291         -2     
==================================================
  Files            2036       2036                
  Lines           96346      96348         +2     
  Branches        16831      16831                
==================================================
- Hits            50430      50427         -3     
- Misses          38492      38497         +5     
  Partials         7424       7424                
Files with missing lines Coverage Δ
...groovy/grails/testing/web/GrailsWebUnitTest.groovy 100.0000% <100.0000%> (ø)
.../grails/testing/ParameterizedGrailsUnitTest.groovy 0.0000% <0.0000%> (ø)
...testing/web/interceptor/InterceptorUnitTest.groovy 0.0000% <0.0000%> (ø)
...vy/grails/testing/web/taglib/TagLibUnitTest.groovy 25.0000% <50.0000%> (ø)
...oovy/grails/testing/web/UrlMappingsUnitTest.groovy 12.1951% <40.0000%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matrei
matrei force-pushed the test-support-type-hints branch from 4bba194 to 2c80e3e Compare August 4, 2026 13:35
@testlens-app

testlens-app Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚨 TestLens detected 1 failed test 🚨

Here is what you can do:

  1. Inspect the test failures carefully.
  2. If you are convinced that some of the tests are flaky, you can mute them below.
  3. Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

CI - Groovy Joint Validation Build / build_grails > :grails-datamapping-core-test:test

Test Runs Flakiness
CoreTestSuite ✅ ❌ 1% 🟡

CI - Groovy Joint Validation Build / build_grails > :grails-test-examples-spring-security-ui-extended:integrationTest

Test Runs Flakiness
ExtendedSecurityInfoSpec > testFilterChains ❌ ✅ 1% 🟡

🏷️ Commit: 2c80e3e
▶️ Tests: 59954 executed
⚪️ Checks: 62/62 completed

Test Failures

CoreTestSuite (:grails-datamapping-core-test:test in CI - Groovy Joint Validation Build / build_grails)
org.junit.platform.suite.engine.NoTestsDiscoveredException: Suite [org.grails.datastore.gorm.CoreTestSuite] did not discover any tests
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)

Muted Tests

Select tests to mute in this pull request:

  • CoreTestSuite
  • ExtendedSecurityInfoSpec > testFilterChains

Reuse successful test results:

  • ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

  • Rerun jobs

Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant