[server] Parallelize replica leader transitions - #3999
Open
zuston wants to merge 1 commit into
Open
Conversation
Member
Author
|
could you help review this? @fresh-borzoni |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR speeds up replica leader transitions by processing independent buckets concurrently within a
NotifyLeaderAndIsrrequest.Previously,
ReplicaManager.makeLeaders()transitioned replicas sequentially. This could significantly increase request latency when multiple replicas became leaders together, especially for primary-key tables where leader initialization may involve restoring RocksDB state from remote snapshots and replaying logs.Brief change log
Introduce the option of
tablet-server.replica-transition-thread-numto control concurrency, with a default value of 10.And in the first phase of this PR, we haven't involve the
makeFollowersinto the backgroud thread pools.Tests
API and Format
Documentation