[hotfix][runtime-web] Restyle Cancel Job/Application action as a danger button#28499
Open
spuru9 wants to merge 1 commit into
Open
[hotfix][runtime-web] Restyle Cancel Job/Application action as a danger button#28499spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
…er button The Cancel action on the Job and Application detail pages rendered as an oversized 24px blue text link — inconsistent with the sibling action links (e.g. "Job Manager Log") and not signalling that it is a destructive action. Render it as a small ng-zorro danger button (red outline, fills solid red on hover with a smooth transition). Styling only — the confirmation dialog and cancel behaviour are unchanged.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The Cancel action on the Job and Application detail pages renders as an oversized 24px blue text link. That's inconsistent with the sibling action links (e.g. "Job Manager Log") and doesn't visually signal that it is a destructive action. This restyles it as a small danger button.
Brief change log
nz-button nzDanger nzSize="small"instead of a 24px<a>text linkBefore:


After:


Verifying this change
Frontend-only styling change, verified manually: open a running job's (and a running application's) detail page and confirm the Cancel action renders as a small red danger button that fills on hover, and that the confirmation dialog and cancellation still work.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?