[FLINK-39772][tests][JUnit5 migration] Module: flink-fs-tests#28497
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-39772][tests][JUnit5 migration] Module: flink-fs-tests#28497spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
Collaborator
621df3c to
ee5bd24
Compare
Contributor
Author
ee5bd24 to
8ea2fa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate the remaining JUnit 4 tests in
flink-fs-teststo JUnit 5 (Jupiter). After this PR the module has zero JUnit 4 imports. Part of the umbrella JUnit 4 → 5 migration.JIRA: FLINK-39772 (sub-task of FLINK-25325)
Brief change log
Five test classes migrated (all under
org.apache.flink.hdfstests):HDFSTest—@Rule/@ClassRule TemporaryFolder→@TempDir,@Before*/@After*→@BeforeEach/@AfterEach/@BeforeAll,Assume.assumeTrue→Assumptions.assumeTrue(arg order swapped).DistributedCacheDfsTest— droppedextends TestLogger;@ClassRule MiniClusterWithClientResource→@RegisterExtension static MiniClusterExtension;@ClassRule TemporaryFolder→@TempDir.ContinuousFileProcessingITCase—extends AbstractTestBaseJUnit4→extends AbstractTestBase(the JUnit 5 sibling); lifecycle annotations.ContinuousFileProcessingTest— lifecycle annotations,@ClassRule TemporaryFolder→@TempDir(+TempDirUtils).ContinuousFileProcessingMigrationTest(parameterized) —@RunWith(Parameterized.class)→@ExtendWith(ParameterizedTestExtension.class)with@Parameterfield injection and@TestTemplate;@SnapshotsGeneratormethods keptpublic(the migration framework discovers them viaClass#getMethods()).org.junit.*imports removed;publicdropped from test classes/methods per the Flink JUnit 5 Migration Guide.One assertion in
testReaderSnapshotRestorekeepsCollection#contains(...)(rather than AssertJ'sassertThat(coll).contains(...)) on purpose:FileInputSplit#equalsis asymmetric with itsTimestampedFileInputSplitsubclass, and AssertJ reverses theequalsdirection. A comment documents this.No production code is touched.
Verifying this change
This change is a test-only migration covered by the existing tests it migrates:
Result: 50 tests run, 0 failures, 0 errors, 0 skipped, matching the pre-migration baseline.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?