[FLINK-39769][tests][JUnit5 migration] Module: flink-examples-streaming#28496
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-39769][tests][JUnit5 migration] Module: flink-examples-streaming#28496spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
…examples-streaming Migrate the remaining JUnit 4 tests in flink-examples-streaming to JUnit 5: - StreamingExamplesITCase and SocketWindowWordCountITCase: replace @RunWith(Parameterized.class) with the Flink ParameterizedTestExtension (@ExtendWith + @Parameter/@Parameters/@testtemplate) and move the base class from AbstractTestBaseJUnit4 to AbstractTestBase. - TopSpeedWindowingExampleITCase: drop TestLogger and replace the @ClassRule MiniClusterWithClientResource / TemporaryFolder with @RegisterExtension MiniClusterExtension and @tempdir. - Convert the remaining org.junit.Assert.fail to AssertJ.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate the remaining JUnit 4 tests in
flink-examples/flink-examples-streamingto JUnit 5 (Jupiter). After this PR the module has zero JUnit 4 imports. Part of the umbrella JUnit 4 → 5 migration.JIRA: FLINK-39769 (sub-task of FLINK-25325)
Brief change log
Three test classes migrated:
StreamingExamplesITCaseandSocketWindowWordCountITCase(parameterized):@RunWith(Parameterized.class)→@ExtendWith(ParameterizedTestExtension.class).@Parameterized.Parameter→@Parameter;@Parameterized.Parameters→@Parameters(name = ...).@Test→@TestTemplate(required for the parameterized extension).extends AbstractTestBaseJUnit4→extends AbstractTestBase(the JUnit 5 sibling).org.junit.Assert.fail→org.assertj.core.api.Assertions.fail(SocketWindowWordCountITCase).TopSpeedWindowingExampleITCase:@ClassRule MiniClusterWithClientResource→@RegisterExtension static MiniClusterExtension.@ClassRule TemporaryFolder→@TempDir static File;newFile()/newFolder()→new File(tempDir, ...).extends TestLogger;org.junit.Test→org.junit.jupiter.api.Test.publicon test classes and methods per the Flink JUnit 5 Migration Guide.No production code is touched.
Verifying this change
This change is a test-only migration covered by the existing tests it migrates:
Result: 11 tests run, 0 failures, 0 errors, 0 skipped (
StreamingExamplesITCase8,SocketWindowWordCountITCase2,TopSpeedWindowingExampleITCase1), matching the pre-migration baseline.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?