[hotfix][postgres] generateCreateTableEvent result is skipped - #4490
Open
CatOrLeader wants to merge 1 commit into
Open
[hotfix][postgres] generateCreateTableEvent result is skipped #4490CatOrLeader wants to merge 1 commit into
CatOrLeader wants to merge 1 commit into
Conversation
Adopt the usage of the function call result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
For now, the
PostgresPipelineRecordEmitterclass in the constructor callgenerateCreateTableEventfunction and throws away the result of the metadata scan. This pull request fixes it and adds table DDL into the local cache map.Brief change log
Changed the name of the inner map inside the function
generateCreateTableEventto avoid shadowing of the original class field. Additionally, add all the resulting maps into the cache.Verifying this change
This change is a trivial rework.
Documentation
Was generative AI tooling used to co-author this PR?