[FLINK-39492][starrocks] Fix microsecond precision loss for TIMESTAMP types in StarRocks sink#4404
Open
ThorneANN wants to merge 1 commit into
Open
Conversation
ThorneANN
changed the title
yuxiqian
reviewed
May 24, 2026
Member
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
Adding integrated tests / E2e cases would be nice.
| if (precision <= 0) { | ||
| return DATETIME_FORMATTER; | ||
| } | ||
| if (precision < DATETIME_FORMATTERS.length) { |
Member
There was a problem hiding this comment.
The maximal precision for temporal types is 9. We may add a precondition guard here, and remove the non-caching branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIMESTAMP_WITHOUT_TIME_ZONE and TIMESTAMP_WITH_LOCAL_TIME_ZONE fields were
serialized using a hardcoded "yyyy-MM-dd HH:mm:ss" formatter, silently
dropping sub-second precision regardless of the declared column precision.
Add datetimeFormatter(int precision), mirroring the existing timeFormatter,
which appends fractional seconds only when precision > 0. The formatter
instances are cached per precision to avoid repeated allocation.
For StarRocks < 3.1, the fractional part is truncated by the server on
ingestion — no behavioral regression. For StarRocks >= 3.1 (which supports
microsecond DATETIME storage), full precision is now preserved end-to-end.