Skip to content

Fix: Correct parameter comparison in updatePostDatedChecks validation… - #6310

Open
jaysharmagithub wants to merge 1 commit into
apache:developfrom
jaysharmagithub:fix/post-dated-checks-logic
Open

Fix: Correct parameter comparison in updatePostDatedChecks validation…#6310
jaysharmagithub wants to merge 1 commit into
apache:developfrom
jaysharmagithub:fix/post-dated-checks-logic

Conversation

@jaysharmagithub

Copy link
Copy Markdown

Description

This Pull Request corrects a copy-paste logic bug in the updatePostDatedChecks method inside PostDatedChecks.java.

Previously, the condition for checking a change in the check number parameter was comparing the new input value against this.accountNo instead of this.checkNo:
if (command.isChangeInLongParameterNamed("checkNo", this.accountNo))

This error causes unexpected validation behaviors when updating check information. This fix switches the parameter reference to the correct field variable:
if (command.isChangeInLongParameterNamed("checkNo", this.checkNo))

Impact

  • Corrects data validation accuracy for updating post-dated checks.
  • Prevents potential bugs where a check number matching the account number fails to update.
  • No runtime breaking changes or structural updates.

Verifications

  • Code compiles cleanly locally using ./gradlew compileJava.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant