Skip to content

FINERACT-2649: Migrate Tier 1 loan integration tests to Feign client#6005

Open
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2649/batch-migrate-loan-tests-to-feign-s1
Open

FINERACT-2649: Migrate Tier 1 loan integration tests to Feign client#6005
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2649/batch-migrate-loan-tests-to-feign-s1

Conversation

@DeathGun44

Copy link
Copy Markdown
Contributor

Description

Migrates 5 Tier 1 loan integration tests from BaseLoanIntegrationTest (REST-assured) to FeignLoanTestBase (Feign client).

Migrated tests

  • LoanPrepayAmountTest
  • LoanProductWithChargeOffBehaviourTest
  • LoanInterestRateFrequencyTest
  • LoanDueCalculationTest
  • FixedLengthLoanProductIntegrationTest

Infrastructure additions

  • Added retrieveLoanProduct and updateLoanProduct (typed) methods to FeignLoanHelper
  • Added updateLoanProduct(Long, String) raw JSON overload in FeignLoanTestBase for explicit null values (the NON_NULL ObjectMapper prevents typed null serialization)
  • Added REST-assured requestSpec/responseSpec to FeignLoanTestBase for raw JSON edge cases
  • Added fixedLengthLoanProduct template to LoanProductTemplates
  • Added payment allocation helpers and loan request builders to LoanRequestBuilders
  • Added schedule validation helpers to LoanTestValidators

Bug fixes

  • FeignClientHelper.createClient() - use fixed past activation date (04 March 2011) matching ClientHelper.DEFAULT_DATE instead of real system date
  • FeignBusinessDateHelper - date format fixed to use DATETIME_PATTERN (dd MMMM yyyy)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant