FINERACT-2421: Allow using Mysql / Mariadb db clients for development…#6004
FINERACT-2421: Allow using Mysql / Mariadb db clients for development…#6004adamsaghy wants to merge 1 commit into
Conversation
… (devRun/bootRun)
meonkeys
left a comment
There was a problem hiding this comment.
LGTM.
Dev only should be fine. According to FINERACT-2572, as long as we don't ship category X drivers we are good. Meaning, they can't be in apache-fineract-bin-$VERSION.tar.gz, and they can only be in the Docker image if they're added similar to how you might install an OS package (e.g. apt-get install libfoo).
I just ran ./gradlew srcDistTar binaryDistTar -x test and inspected fineract-war/build/distributions/apache-fineract-bin-1.15.0-SNAPSHOT.tar.gz. That tarball has fineract-provider-1.15.0-SNAPSHOT.jar and that jar has only BOOT-INF/lib/postgresql-42.7.11.jar. So I think the binary release will be clean.
To check the Docker image I built with ./gradlew jibDockerBuild then started a container with
docker run --rm -it --entrypoint sh fineractI poked around in the container and the only db driver I see is /app/libs/postgresql-42.7.11.jar.
|
@adamsaghy Its ok to merge but i think you can maintain description for the change. While explaining the changes in description |
… (devRun/bootRun)
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.