FINERACT-2259: Manage external IDs: Savings (transactions)#5801
FINERACT-2259: Manage external IDs: Savings (transactions)#5801San-43 wants to merge 2 commits intoapache:developfrom
Conversation
- add savings transaction routes by savings account externalId - support transaction operations by transaction externalId - add externalId support for holdAmount, releaseAmount and postInterestAsOn - align savings transaction validation and OpenAPI metadata - add focused tests for savings transaction externalId flows
|
integration test failures were caused by three regressions introduced by these changes:
There were also two PS: e2e test failures are unrelated I believe I fixed these regressions and the affected tests in my last commit. @adamsaghy please take a look when u have a time, i may need some guidance here. |
|
After the latest changes, the remaining failing tests don’t appear to be caused by this PR they’re failing with |
|
|
IOhacker
left a comment
There was a problem hiding this comment.
@San-43 LGTM @Aman-Mittal still 1 commit per PR applies?
|
Hi @IOhacker, thank you for your LGTM and comment. About the two commits: I read FSIP-7: Traditional Merge Strategy the other day and wanted to keep this PR as two commits because I think it better reflects the fixes made along the way. However, i'm happy to squash into one commit if needed. |
While FSIP-7 proposal intention was to preserve sign commits for merge instead of "Squash and Commit" it should be merged normally. While it is also mentioned. Encourage developers to use as few or as many commits as they choose in their PRs, with the intent to most clearly communicate the reviewable progress of their work during PR review and for posterity. This means rebasing locally, adding/removing commits, and force-pushing are all still allowed, although these should be used only as necessary/helpful (e.g. when a new commit on develop assists the PR or to correct noise/mistakes). If force-push is used, communicate it thoughtfully. Its up to you (reviewer) if you want him rebase or not is multiple commits justify for the work he has done. |
This PR completes savings transaction externalId support:
Checklist
Your assigned reviewer(s) will follow our guidelines for code reviews.