FINERACT-2592: It does not allow rescheduling.#5791
Open
EDSONZ-WASSWA wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2592: It does not allow rescheduling.#5791EDSONZ-WASSWA wants to merge 1 commit intoapache:developfrom
EDSONZ-WASSWA wants to merge 1 commit intoapache:developfrom
Conversation
Contributor
|
@EDSONZ-WASSWA We are not accepting WEB Jira ticket for backend changes. Please create an appropriate Apache Fineract JIRA ticket for this changes! |
5768c73 to
4463d21
Compare
Contributor
|
@EDSONZ-WASSWA make sure you have signed your commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Background
When a borrower misses several payments, Fineract calculates penalty charges on each overdue installment. Up until this change, attempting to reschedule such a loan would fail immediately with a not.allowed.due.to.overdue.charges validation error, making it impossible to help borrowers who genuinely needed their repayment schedule restructured.
This was a real gap the most common reason a lender reschedules a loan is precisely because the borrower has fallen behind.
What this PR does
The system used to stop loan rescheduling completely whenever overdue penalty charges existed. Now it doesn't have to.
There's a new optional flag " waiveOverdueCharges" that a lender can pass when approving a reschedule. Set it to true and the system clears all outstanding overdue penalties right before building the new repayment schedule.
This practically makes sense:
when restructuring a loan, the lender usually wants to clear those penalties as part of the deal, so this just handles it in one step instead of two.
Leave the flag out or set it to false and nothing changes the original block stays in place. No decision made, no charges touched.
For the actual waiving, it hooks straight into the existing charge waiver logic, so you get the same audit trail and transaction records as a manual waiver through the User interface (UI).
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.
this is the link to the jira ticket https://mifosforge.jira.com/issues?filter=-1&selectedIssue=WEB-479