FINERACT-2255: New command processing - external Assets Owner (org.apache.fineract.investor)#5773
Conversation
40e82b4 to
b603176
Compare
|
@adamsaghy kindly rerun test on the failed check "E2E Tests (Shard 8 of 15)". thanks |
|
@adamsaghy @vidakovic pls do review this PR when u have the time, thanks |
|
@elnafateh ... this PR is missing the goal of the refactoring... I don't see anywhere the new CommandDispatch being used... please read instructions again or contact me. As is can't be merged. |
|
@vidakovic thanks for the feedback. I have read (studied) Instruction again for both parent FINERACT-2169 and the child FINERACT-2255 Tickets. Now here's my Initial plan to completing FINERACT-2255 remaining work. Since the description Itemized the work from 1-6, with item 1. PR #451 covering some parts item 1, I intended to complete item 2. PR #5773 which only treats everything "READ" and then open another PR for item 3. Treat everything "WRITE" which is where "new CommandDispatch" is gonna come in and so does the rest of them items, each will have seperate PR under same ticket.. what do u make of this approach? your feedback is essential! |
|
@elnafateh I'd do this in one PR... splitting this up doesn't really help and probably creates more confusion. Just look at one of the completed tickets under FINERACT-2169 (I suggest "notes", dead easy)... that gives you a template on what and how to do this. |
|
@vidakovic I have started the impl based on the approach you suggested. |
|
@vidakovic the shared POST /transfers/loans/{loanId}?command=sale|buyback|intermediarySale endpoint makes it difficult to apply Jakarta Validation cleanly since each command has different required fields. |
b603176 to
40de112
Compare
40de112 to
0006c56
Compare
|
@vidakovic kindly review the update |
Description
New command processing - external Assets Owner
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.