FINERACT-2589: [HOTFIX] Fix repayment template next unpaid installment amount

[shamir92]

Description

Updated the repayment transaction template query so it returns the next installment with an outstanding balance instead of always defaulting to the earliest installment.

This was needed because partially paid loans could produce an incorrect repayment template amount when the first matching installment was already fully satisfied. The change reuses the existing due amount expressions in the query ordering, and adds an integration test to verify the repayment template now returns the next unpaid installment amount.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[San-43]

Please sign your commits as described in the CONTRIBUTING.md signing guide. Also, please use the required PR title format FINERACT-XXXX: Small descriptive sentence -- your pr should always reference a Jira ticket.

[AshharAhmadKhan]

@shamir92 please follow everything @San-43 said. Reference the relevant jira ticket.

[shamir92]

hi @AshharAhmadKhan
yep.
i am on request of jira access to fineract. but not yet approved. from 3 day ago.

[adamsaghy]

hi @AshharAhmadKhan yep. i am on request of jira access to fineract. but not yet approved. from 3 day ago.

@shamir92 Done ;)

[shamir92]

hi @AshharAhmadKhan yep. i am on request of jira access to fineract. but not yet approved. from 3 day ago.

@shamir92 Done ;)

hi, i already change the title and add jira ticket for this pr.

[AshharAhmadKhan]

hi @AshharAhmadKhan yep. i am on request of jira access to fineract. but not yet approved. from 3 day ago.

@shamir92 Done ;)

hi, i already change the title and add jira ticket for this pr.

check the failing logs.

[shamir92]

How do i re run the failing jobs ?

[adamsaghy]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':fineract-provider:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
          @@ -2138,14 +2138,14 @@
           ····················+·penaltyDueExpression;
           
           ············return·"·GREATEST(loan_transaction.transaction_date,·ls.dueDate)·as·transactionDate,"·+·"·"·+·principalDueExpression
          -····················+·"·as·principalDue,"·+·"·"·+·interestDueExpression·+·"·as·interestDue,"·+·"·"·+·feeDueExpression·+·"·as·feeDue,"
          -····················+·"·"·+·penaltyDueExpression·+·"·as·penaltyDue,"
          -····················+·"·l.currency_code·as·currencyCode,"·+·"·l.currency_digits·as·currencyDigits,"
          -····················+·"·l.currency_multiplesof·as·inMultiplesOf,"·+·"·l.net_disbursal_amount·as·netDisbursalAmount,"·+·"·rc."
          -····················+·sqlGenerator.escape("name")·+·"·as·currencyName,"·+·"·rc.display_symbol·as·currencyDisplaySymbol,"
          -····················+·"·rc.internationalized_name_code·as·currencyNameCode"·+·"·FROM"·+·"·m_loan·l"·+·"·JOIN·m_currency·rc·on·rc."
          -····················+·sqlGenerator.escape("code")·+·"·=·l.currency_code"·+·"·JOIN·m_loan_repayment_schedule·ls·ON·ls.loan_id·=·l.id"
          -····················+·"·LEFT·JOIN·("·+·"·select·tr.loan_id,·max(tr.transaction_date)·as·transaction_date"·+·"·from·m_loan_transaction·tr"
          +····················+·"·as·principalDue,"·+·"·"·+·interestDueExpression·+·"·as·interestDue,"·+·"·"·+·feeDueExpression·+·"·as·feeDue,"·+·"·"
          +····················+·penaltyDueExpression·+·"·as·penaltyDue,"·+·"·l.currency_code·as·currencyCode,"
          +····················+·"·l.currency_digits·as·currencyDigits,"·+·"·l.currency_multiplesof·as·inMultiplesOf,"
          +····················+·"·l.net_disbursal_amount·as·netDisbursalAmount,"·+·"·rc."·+·sqlGenerator.escape("name")·+·"·as·currencyName,"
          +····················+·"·rc.display_symbol·as·currencyDisplaySymbol,"·+·"·rc.internationalized_name_code·as·currencyNameCode"·+·"·FROM"
          +····················+·"·m_loan·l"·+·"·JOIN·m_currency·rc·on·rc."·+·sqlGenerator.escape("code")·+·"·=·l.currency_code"
          +····················+·"·JOIN·m_loan_repayment_schedule·ls·ON·ls.loan_id·=·l.id"·+·"·LEFT·JOIN·("
          +····················+·"·select·tr.loan_id,·max(tr.transaction_date)·as·transaction_date"·+·"·from·m_loan_transaction·tr"
           ····················+·"·where·tr.transaction_type_enum·in·(?,?)"·+·"·AND·tr.is_reversed·=·false"·+·"·group·by·tr.loan_id"
           ····················+·"·)·loan_transaction·ON·loan_transaction.loan_id·=·l.id"·+·"·WHERE·l.id·=·?"·+·"·ORDER·BY·CASE·WHEN·("
           ····················+·totalDueExpression·+·")·>·0·THEN·0·ELSE·1·END,·ls.installment"·+·"·LIMIT·1";
  Run './gradlew :fineract-provider:spotlessApply' to fix these violations.

[adamsaghy]

@shamir92 Seems like you havent configured GPG signature to your account yet.