Fix StackOverflow when exporting POJOs with custom converters#899
Open
utafrali wants to merge 1 commit intoapache:mainfrom
Open
Fix StackOverflow when exporting POJOs with custom converters#899utafrali wants to merge 1 commit intoapache:mainfrom
utafrali wants to merge 1 commit intoapache:mainfrom
Conversation
Exclude circular reference fields from @EqualsAndHashCode to prevent infinite recursion during POJO export. Closes apache#889
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closes #889
Fixes the stack overflow error that happens when exporting POJOs with custom converters.
What's changed?
The issue was @EqualsAndHashCode trying to hash the entire object graph, including parent references. Since WriteSheetHolder has parentWriteWorkbookHolder and WriteTableHolder has parentWriteSheetHolder, these circular references caused infinite recursion during equals/hashcode generation.
Excluded those parent fields from the @EqualsAndHashCode annotation. This breaks the circular dependency without affecting the equality logic for these holders. Also added tests for the ZonedDateTime converter to make sure custom converters work properly with the fix.
Checklist