docs: add Alibaba attribution to legacy-derived files in fesod-sheet#898
docs: add Alibaba attribution to legacy-derived files in fesod-sheet#898skytin1004 wants to merge 3 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Hi, @skytin1004
FYI, FastExcel, FastExcelFactory, and FesodSheet are not derived from Alibaba's EasyExcel.
|
Thanks @delei for the clarification. I've removed the attribution blocks from For the remaining three files, I kept the attribution based on their copy history from existing files that already retain Alibaba attribution:
If these should also be treated as FastExcel/Fesod-added files, I'm happy to update them accordingly. |
|
AFAIK, all of these files were added during the FastExcel/Fesod development phase and were not derived from Alibaba EasyExcel.
Their design purpose and implementation scope differ significantly from the EasyExcel test/demo classes mentioned in the discussion. Additionally, Therefore, IMO these files do not require additional Alibaba copyright statement. |
|
Hi @bengbengbalabalabeng Since these files are not derived from EasyExcel, I'll go ahead and close this PR. Please feel free to reopen or let me know if I missed anything. |
Purpose of the pull request
Related: #878
This PR adds the Alibaba attribution block to 6
fesod-sheetfiles that appear to be legacy EasyExcel-derived or legacy-derived files.What's changed?
I reviewed the Java files in
fesod-sheetand checked the remainingASF-onlyfiles against git history, prior refactor commits, and existing files that already keep Alibaba attribution.I scanned attribution across the module
fesod-sheetBased on that review, I identified 6 files with clear evidence of derivation from legacy EasyExcel code or legacy-derived test data, and added the required Alibaba attribution block after the ASF license header:
FesodSheet.javaFastExcel.javaFastExcelFactory.javaMaxHeadSizeData.javaHiddenSheetsData.javaWriteSheetData.javaI selected these files conservatively based on the following evidence:
FesodSheet.javatraces back to the legacy core API (EasyExcel.java/EasyExcelFactory.java) viagit log --followFastExcel.javais part of the EasyExcel-to-FastExcel compatibility/rename path and retained as a deprecated aliasFastExcelFactory.javafollows the same legacy factory path and is kept as a deprecated compatibility aliasMaxHeadSizeData.javawas copied fromComplexHeadData.java, which already retains Alibaba attributionHiddenSheetsData.javawas copied fromMultipleSheetsData.java, which already retains Alibaba attributionWriteSheetData.javawas copied fromNoHeadData.java, which already retains Alibaba attributionI intentionally kept this PR narrow and did not update the other remaining
ASF-onlyfiles infesod-sheet, because their introduction commits indicate they are FastExcel/Fesod-added feature, bugfix, fuzz, or unit-test files.Checklist