fix(tree): apply selected line style to edges. close #18214#21681
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(tree): apply selected line style to edges. close #18214#21681rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Applies configured
select.lineStyleto tree node edges when tree nodes are selected.Fixed issues
select.lineStyledid not affect the selected node's branch/edge.Details
Before: What was the problem?
Tree node symbols could enter the
selectstate correctly, soselect.itemStyleworked on the selected node.However, the tree edge/branch is rendered as a sibling element of the node symbol group, not as a child of it. The generic selection update only marks the node symbol group as selected, so the edge never entered the
selectstate even though itsselect.lineStylestate style was already configured.After: How does it behave after the fixing?
Tree edges now mirror the selection state of their corresponding tree nodes.
The fix updates tree edge selection in
TreeViewby applyingenterSelect/leaveSelectto each node edge based onseriesModel.isSelected(dataIndex). It runs after render and duringselect,unselect, andtoggleSelectactions, so both initial selected state and later selection changes are handled.A regression unit test was added to verify that:
select.lineStyle.coloris stored on the tree edge select state;Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/ut/spec/series/tree.test.tsValidation run:
Merging options
Other information
N.A.