fix(legend): respect scroll legend width. close #12562#21680
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(legend): respect scroll legend width. close #12562#21680rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Respect
legend.widthas the maximum cross-axis size for vertical scroll legends and clip overflowing legend content.Fixed issues
widthon a scroll legend did not constrain long legend item text.Details
Before: What was the problem?
For a vertical scroll legend,
legend.widthwas not treated as the visible maximum width of the scrollable legend content.When legend item names were very long, the legend content and background could expand beyond the configured
width, so the option below did not keep the legend within the expected width:After: How does it behave after the fixing?
Vertical scroll legends now cap the visible cross-axis size by the configured
width.The fix computes the visible main rectangle using the smaller of the measured content/controller width and the configured max width. It also applies clipping when the content overflows the configured cross-axis size, even if page controls are not needed.
A regression test was added to verify that a vertical scroll legend with long item names keeps both the background and clip rectangle within the configured
legend.width.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/ut/spec/component/legend/scrollableLegend.test.tsValidation run:
Merging options
Other information
N.A.