fix(graph): edge endpoints follow symbol shape. close #10563#21677
Open
AstrorEnales wants to merge 1 commit into
Open
fix(graph): edge endpoints follow symbol shape. close #10563#21677AstrorEnales wants to merge 1 commit into
AstrorEnales wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
This PR improves the edge adjustment in graph series for different symbol shapes. Previously, the endpoints of edges were positioned on a circle around the actual node symbol. This resulted in edge endpoints sometimes being hidden behind the symbol and sometimes too far away. The new logic uses exact formulas for some symbol types and intersections for more complex paths. For data image symbols the rectangular outline of the symbol is used.
Fixed issues
Details
Before: What was the problem?
Endpoints of edges were positioned on a circle around the actual node symbol. This resulted in edge endpoints sometimes being hidden behind the symbol and sometimes too far away.
After: How does it behave after the fixing?
The new logic uses exact formulas for some symbol types and intersections for more complex paths. For data image symbols the rectangular outline of the symbol is used.
Document Info
One of the following should be checked.
Misc
Related test cases or examples to use the new APIs