Detect ip:port with contains in NetUtils.matchIpExpression#16358
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Detect ip:port with contains in NetUtils.matchIpExpression#16358vasiliy-mikhailov wants to merge 1 commit into
vasiliy-mikhailov wants to merge 1 commit into
Conversation
The deprecated two-arg matchIpExpression used address.endsWith(":") to detect the ip:port format, but a real address like 192.168.1.63:90 ends with the port, not a colon, so the host/port split was skipped and matching failed. Use contains(":") to detect the separator.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16358 +/- ##
============================================
- Coverage 60.80% 60.76% -0.04%
- Complexity 15 11766 +11751
============================================
Files 1953 1953
Lines 89208 89197 -11
Branches 13458 13375 -83
============================================
- Hits 54245 54205 -40
+ Misses 29397 29376 -21
- Partials 5566 5616 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecated two-arg
matchIpExpression(pattern, address)usesaddress.endsWith(":")to detect theip:portformat. A real address such as192.168.1.63:90ends with the port, not a colon, so the host/port split is skipped — the fullhost:portstring is then used as the host and matching fails. Usecontains(":")to detect the separator.Added a test covering
ip:portaddresses against patterns with and without a port.Verifying this change
The added
NetUtilsTest#testMatchIpExpressionDeprecatedTwoArgsWithIpPortfails before this change and passes after:Before the fix:
After the fix:
AI assistance disclosure
This contribution was produced with the help of an AI pipeline. The pipeline processed a large amount of source code to surface suspected bugs, reproduced a subset of them with failing unit tests and generated candidate fixes, and prepared pull requests from the ones that held up. Each PR was then reviewed and verified by a human before being opened: the fix and test were checked by hand and the test was confirmed to fail before the change and pass after.