fix(ai): bump bytedance/sonic to v1.15.0 for Go 1.26 build support - #1532
Open
ambiguous-pointer wants to merge 1 commit into
Open
fix(ai): bump bytedance/sonic to v1.15.0 for Go 1.26 build support#1532ambiguous-pointer wants to merge 1 commit into
ambiguous-pointer wants to merge 1 commit into
Conversation
Fixes apache#1529 The ai module fails to build on Go >= 1.26 hosts because the transitive dependency bytedance/sonic v1.14.1 binds to the old map internals via //go:linkname (undefined: GoMapIterator). v1.15.0 fixed it upstream (bytedance/sonic#898). Upgraded sonic to v1.15.0 plus sonic/loader v0.5.0 and cloudwego/base64x v0.1.6 per go mod tidy. Verified with go1.26.4: go build passes, server starts, SSE chat works end-to-end (qwen3.7-max, 4,674 tokens).
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ai/ Go module’s dependency set to restore successful builds on Go >= 1.26 by upgrading the transitive JSON dependency chain (notably github.com/bytedance/sonic) to versions compatible with the Go 1.26 runtime/map iterator changes.
Changes:
- Bumps
github.com/bytedance/sonictov1.15.0andgithub.com/bytedance/sonic/loadertov0.5.0inai/go.mod. - Keeps
ai/go.sumin sync with the upgraded modules (and drops no-longer-needed sums fromgo mod tidy).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ai/go.mod |
Updates indirect dependency versions to pull in sonic fixes required for Go 1.26 builds. |
ai/go.sum |
Refreshes module checksums consistent with the dependency upgrades and tidy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1529
The ai module fails to build on Go >= 1.26 hosts because the transitive dependency bytedance/sonic v1.14.1 binds to the old map internals via //go:linkname (undefined: GoMapIterator). v1.15.0 fixed it upstream (bytedance/sonic#898). Upgraded sonic to v1.15.0 plus sonic/loader v0.5.0 and cloudwego/base64x v0.1.6 per go mod tidy.
Verified with go1.26.4: go build passes, server starts, SSE chat works end-to-end (qwen3.7-max, 4,674 tokens).
Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.