build(deps): Properly document Javassist MPL 1.1 triple-licensing#19586
Open
ashwintumma23 wants to merge 1 commit into
Open
build(deps): Properly document Javassist MPL 1.1 triple-licensing#19586ashwintumma23 wants to merge 1 commit into
ashwintumma23 wants to merge 1 commit into
Conversation
Javassist is triple-licensed under MPL 1.1, LGPL 2.1, and Apache License 2.0. Apache Druid uses it under Apache 2.0 terms. Changes: 1. Add MPL 1.1 as a recognized license in check-licenses.py 2. Update Javassist entry in licenses.yaml to declare MPL 1.1 as its primary license with a notice explaining the triple-licensing and that we use it under Apache 2.0 terms This addresses review feedback to properly canonicalize MPL 1.1 to its own license name rather than hiding it by mapping to Apache 2.0. Addresses: Review comment from FrankChen021 on PR apache#19566
ashwintumma23
changed the title
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 2 of 2 changed files.
This is an automated review by Codex GPT-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Properly document Javassist's triple-licensing (MPL 1.1, LGPL 2.1, Apache License 2.0) in the license metadata. Apache Druid uses Javassist
under the Apache License 2.0 terms, which is permitted by the triple-licensing.
This fixes the "Unsupported license: MPL 1.1" error in the license checker by:
check-licenses.pylicenses.yamlto declare MPL 1.1 as its primary license (as reported by Maven POM)Addresses review feedback from FrankChen021 to properly canonicalize MPL 1.1 to its own license name rather than hiding it by mapping to
Apache 2.0.
Release note
Not applicable - license metadata only, no functional changes.
This PR has:
PR doesn't have any relation to concurrency.)
coverage is met.
Key changed/added classes in this PR
distribution/bin/check-licenses.py- Added MPL 1.1 license recognitionlicenses.yaml- Updated Javassist license metadata with triple-licensing noticeUse this description in the PR form! All checkboxes are appropriately marked based on what this PR actually does (license metadata only).