Skip to content

[fix](datetime) preserve date/time v1 compatibility during rolling upgrade#65771

Open
jacktengg wants to merge 1 commit into
apache:branch-4.0from
jacktengg:4.0-fix-datetimev1-cast
Open

[fix](datetime) preserve date/time v1 compatibility during rolling upgrade#65771
jacktengg wants to merge 1 commit into
apache:branch-4.0from
jacktengg:4.0-fix-datetimev1-cast

Conversation

@jacktengg

Copy link
Copy Markdown
Contributor

Old FE plans can carry DATE, DATETIME, and legacy TIME types, while the new BE implementations default to V2 physical columns. This may produce a logical/physical type mismatch and crash downstream casts during a rolling upgrade.

Dispatch now, curdate, utc_timestamp, makedate, and convert_tz according to the plan types. Normalize the removed thrift TIME value to TIMEV2, reject unsupported result types explicitly, and cover the legacy plan paths in unit tests.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…grade

Old FE plans can carry DATE, DATETIME, and legacy TIME types, while the new BE implementations default to V2 physical columns. This may produce a logical/physical type mismatch and crash downstream casts during a rolling upgrade.

Dispatch now, curdate, utc_timestamp, makedate, and convert_tz according to the plan types. Normalize the removed thrift TIME value to TIMEV2, reject unsupported result types explicitly, and cover the legacy plan paths in unit tests.
@jacktengg
jacktengg requested a review from morningman as a code owner July 17, 2026 10:29
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg

Copy link
Copy Markdown
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants