Skip to content

fix stale output capacity in Lz4BlockDecompressor decompress #64091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahvx655-wq wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

fix stale output capacity in Lz4BlockDecompressor decompress #64091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions be/src/util/decompressor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,10 +552,12 @@ Status Lz4BlockDecompressor::decompress(uint8_t* input, uint32_t input_len,
break;
}

// Decompress this block.
// Decompress this block. Capacity must track output_ptr: remaining_output_len
// is fixed per large block while output_ptr advances per small block.
auto decompressed_small_block_len = LZ4_decompress_safe(
reinterpret_cast<const char*>(input_ptr), reinterpret_cast<char*>(output_ptr),
compressed_small_block_len, remaining_output_len);
compressed_small_block_len,
cast_set<uint32_t>(output_max_len - (output_ptr - output)));
if (decompressed_small_block_len < 0) {
return Status::InvalidArgument("Failed to do Lz4Block decompress, error = {}",
LZ4F_getErrorName(decompressed_small_block_len));
Expand Down
Loading