[refactor](be) Use column check helper for type casts#63946
Open
Mryange wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Replace direct typeid_cast usage for Doris column type checks with the column-specific check_and_get_column helper. This keeps column downcast checks consistent across core column code, expression evaluation, storage segment code, and related table reader tests without changing behavior.
### Release note
None
### Check List (For Author)
- Test: Manual test
- Built BE with sh build.sh --be -j48
- Behavior changed: No
- Does this need documentation: No
Contributor
Author
|
/review |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
No blocking issues found. The changed call sites replace typeid_cast with check_and_get_column, whose current implementation delegates to the same typeid_cast overloads, so the reviewed paths preserve the previous null-on-mismatch behavior and const/mutable pointer semantics.
Critical checkpoint conclusions:
- Goal/test: The PR goal is a focused BE refactor for column type checks. The code accomplishes that goal. The PR body reports a BE build with
sh build.sh --be -j48; I did not rerun the full build in this review runner. - Scope/focus: The code change is small and focused in the actual GitHub diff.
- Concurrency/lifecycle: No new shared state, locking, threads, or lifecycle ownership changes were introduced.
- Configuration/compatibility: No config items, storage formats, RPC/thrift interfaces, or incompatible serialized formats changed.
- Parallel paths: The modified call sites are consistent with existing
check_and_get_columnusage in column helpers. - Error handling: Existing failure behavior is preserved;
check_array_offsets_columnstill throws on mismatch. - Tests: No new tests are needed for this mechanical refactor; touched tests were updated consistently.
- Observability/performance: No new observability need. Performance should be equivalent because the helper inlines to
typeid_cast. - Data correctness/MoW/transaction: No data visibility, delete bitmap, transaction, or persistence behavior changed.
User focus: No additional user-provided review focus was specified.
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 28850 ms |
Contributor
TPC-DS: Total hot run time: 170677 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: Replace direct typeid_cast usage for Doris column type checks with the column-specific check_and_get_column helper. This keeps column downcast checks consistent across core column code, expression evaluation, storage segment code, and related table reader tests without changing behavior.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)