docs(physical-plan): correct the documentation for GroupColumn::vectorized_equal_to#23639
Open
mzabaluev wants to merge 1 commit into
Open
docs(physical-plan): correct the documentation for GroupColumn::vectorized_equal_to#23639mzabaluev wants to merge 1 commit into
GroupColumn::vectorized_equal_to#23639mzabaluev wants to merge 1 commit into
Conversation
Correct the documentation based on the actual behavior in the implementations and at the call sites.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23639 +/- ##
=======================================
Coverage ? 80.65%
=======================================
Files ? 1086
Lines ? 366098
Branches ? 366098
=======================================
Hits ? 295281
Misses ? 53222
Partials ? 17595 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rich-T-kid
approved these changes
Jul 16, 2026
Rich-T-kid
left a comment
Rich-T-kid
left a comment
Contributor
There was a problem hiding this comment.
I don't think the existing comment is necessarily 'incorrect' but I like the more in depth explanation.
Contributor
Author
It says the implementations record the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the documentation based on the actual behavior in the implementations and at the call sites.